Skip to content

Consistent error messaging for field names in query language#734

Open
al-niessner wants to merge 4 commits intodevelopfrom
issue_712
Open

Consistent error messaging for field names in query language#734
al-niessner wants to merge 4 commits intodevelopfrom
issue_712

Conversation

@al-niessner
Copy link
Copy Markdown
Contributor

@al-niessner al-niessner commented Mar 4, 2026

🗒️ Summary

Treat specific field names the same as wildcard field names.

🤖 AI Assistance Disclosure

  • No AI assistance used
  • AI used for light assistance (e.g., suggestions, refactoring, documentation help, minor edits)
  • AI used for moderate content generation (AI generated some code or logic, but the developer authored or heavily revised the majority)
  • AI generated substantial portions of this code

Estimated % of code influenced by AI: ___ %

⚙️ Test Data and/or Report

Automated tests should work as they cover this code block already.

♻️ Related Issues

#712

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Documentation and PR Content

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.
  • Issue Traceability: The PR is linked to a valid GitHub Issue
  • PR Title: The PR title is "user-friendly" clearly identifying what is being fixed or the new feature being added, that if you saw it in the Release Notes for a tool, you would be able to get the gist of what was done.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Maintenance

  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

Check that given field name in the query language is valid throwing same error when they do not.
@al-niessner al-niessner self-assigned this Mar 4, 2026
@al-niessner al-niessner requested a review from a team as a code owner March 4, 2026 19:47
@jordanpadams jordanpadams changed the title 712: consistent error messaging for field names in query language Consistent error messaging for field names in query language Mar 9, 2026
Copy link
Copy Markdown
Member

@tloubrieu-jpl tloubrieu-jpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created by mistake on this PR. I was targeting another PR.

sonarqube made me do it
silly sonarqube is just making the code worse not better. runtimeexception is the correct answer, but this holds truth in that if the state of the system is not repaired, the same error will continue to occur.
@sonarqubecloud
Copy link
Copy Markdown

@jordanpadams
Copy link
Copy Markdown
Member

@al-niessner @tloubrieu-jpl do we have any idea why these branch actions are running in what appears to be an infinite loop?

@al-niessner
Copy link
Copy Markdown
Contributor Author

@jordanpadams Nope.

@jordanpadams
Copy link
Copy Markdown
Member

@al-niessner when you have a chance, can you please try to debug what is going on with the integration tests? We cannot merge any of these updates without the integration tests integrating successfully or at least understand why it is hanging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants